Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Make node.id optional #22815

Merged
merged 2 commits into from
May 24, 2024
Merged

[native] Make node.id optional #22815

merged 2 commits into from
May 24, 2024

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented May 24, 2024 •
edited
Loading

Description

Make node.id optional in line with the Java implementation.
Auto-generate node.id if missing.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Prestissimo (Native Execution)
* Make node.id optional :pr:`22815`

@majetideepak majetideepak requested a review from a team as a code owner May 24, 2024 02:47
@majetideepak majetideepak changed the title [native] Make nodeid optional [native] Make node.id optional May 24, 2024
@majetideepak
Copy link
Collaborator Author

I verified locally that this works.

@majetideepak
Copy link
Collaborator Author

@amitkdutta can you help review this? Thanks.

aditi-pandit
aditi-pandit reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @majetideepak. Had a minor comment.

presto-native-execution/presto_cpp/main/common/Configs.cpp Show resolved Hide resolved
amitkdutta
amitkdutta previously approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.

aditi-pandit
aditi-pandit approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @majetideepak

@aditi-pandit aditi-pandit merged commit fd2cd58 into prestodb:master May 24, 2024
59 checks passed
@amitkdutta amitkdutta mentioned this pull request May 24, 2024
Merged
@majetideepak majetideepak deleted the auto-node-id branch May 25, 2024 05:16
@dnskr dnskr mentioned this pull request Jun 19, 2024
Merged
6 tasks
@wanglinsong wanglinsong mentioned this pull request Jun 25, 2024
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-pandit aditi-pandit aditi-pandit approved these changes

@amitkdutta amitkdutta amitkdutta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majetideepak @amitkdutta @aditi-pandit